fix: use the right user id when changing the email#41539
Open
jvillafanez wants to merge 2 commits intomasterfrom
Open
fix: use the right user id when changing the email#41539jvillafanez wants to merge 2 commits intomasterfrom
jvillafanez wants to merge 2 commits intomasterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Member
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
unit testable? Thank you
Previously, the test only used one user, so it was difficult to verify that the mail was changed for the user2 instead of user1
jvillafanez
force-pushed
the
fix_userid_mail
branch
from
c594d46 to
5e57b95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the email of the right user. Note that the code path isn't reachable from the web UI.
Note that there are checks some lines above for the existence of the user, so if we reach this particular line we know that there is an existing user with that id, no need to check it again.
Related Issue
Motivation and Context
How Has This Been Tested?
Manually tested using curl. It now changes the target user's email instead of the admin's (requester) email.
Screenshots (if appropriate):
Types of changes
Checklist: